Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Implemented post-deployment validation #668

Merged

Conversation

AlexanderSehr
Copy link
Contributor

@AlexanderSehr AlexanderSehr commented Nov 24, 2023

Description

  • Implemented post-deployment validation
  • Improved robustness of diff logic
Pipeline
https://github.com/AlexanderSehr/bicep-registry-modules/actions/runs/6982605270/job/19002095467#step:4:165

Example Output

VERBOSE: Invoke function with
  VERBOSE: {
    "Version": "0.3",
    "ModulePath": "avm/res/key-vault/vault"
  }
  
  VERBOSE: Requested HTTP/1.1 GET with 0-byte payload
  VERBOSE: Received HTTP/1.1 71191-byte response of content type application/json
  VERBOSE: Bicep modules found in MCR catalog:
  
  bicep/samples/hello-world
  bicep/samples/array-loop
  bicep/ai/bing-resource
  bicep/ai/cognitiveservices
  bicep/app/app-configuration
  bicep/app/dapr-containerapp
  bicep/app/dapr-containerapps-environment
  bicep/authorization/resource-scope-role-assignment
  bicep/azure-gaming/game-dev-vm
  bicep/azure-gaming/game-dev-vmss
  bicep/compute/availability-set
  bicep/compute/container-registry
  bicep/compute/custom-image-vmss
  bicep/compute/event-hub
  bicep/compute/function-app
  bicep/cost/resourcegroup-scheduled-action
  bicep/cost/subscription-scheduled-action
  bicep/deployment-scripts/aks-run-command
  bicep/deployment-scripts/aks-run-helm
  bicep/deployment-scripts/build-acr
  bicep/deployment-scripts/create-kv-certificate
  bicep/deployment-scripts/create-kv-sshkeypair
  bicep/deployment-scripts/import-acr
  bicep/deployment-scripts/wait
  bicep/lz/sub-vending
  bicep/identity/user-assigned-identity
  bicep/network/virtual-network
  bicep/network/traffic-manager
  bicep/network/nat-gateway
  bicep/network/dns-zone
  bicep/network/public-ip-address
  bicep/network/public-ip-prefix
  bicep/network/private-dns-zone
  bicep/observability/grafana
  bicep/search/search-service
  bicep/security/keyvault
  bicep/storage/cosmos-db
  bicep/storage/data-explorer
  bicep/storage/storage-account
  bicep/storage/log-analytics-workspace
  bicep/storage/postgresql-single-server
  bicep/storage/redis-cache
  bicep/storage/mysql-single-server
  bicep/avm/res/batch/batch-account
  bicep/avm/res/cognitive-services/account
  bicep/avm/res/compute/ssh-public-key
  bicep/avm/res/event-grid/domain
  bicep/avm/res/event-grid/system-topic
  bicep/avm/res/insights/action-group
  bicep/avm/res/insights/component
  bicep/avm/res/insights/diagnostic-setting
  bicep/avm/res/key-vault/vault
  bicep/avm/res/kubernetes-configuration/extension
  bicep/avm/res/kubernetes-configuration/flux-configuration
  bicep/avm/res/logic/workflow
  bicep/avm/res/network/dns-forwarding-ruleset
  bicep/avm/res/network/dns-resolver
  bicep/avm/res/network/dns-zone
  bicep/avm/res/network/express-route-circuit
  bicep/avm/res/network/express-route-gateway
  bicep/avm/res/network/load-balancer
  bicep/avm/res/network/network-interface
  bicep/avm/res/network/private-dns-zone
  bicep/avm/res/network/private-endpoint
  bicep/avm/res/network/public-ip-address
  bicep/avm/res/operational-insights/workspace
  bicep/avm/res/operations-management/solution
  bicep/avm/res/power-bi-dedicated/capacity
  bicep/avm/res/resource-graph/query
  bicep/avm/res/search/search-service
  bicep/avm/res/sql/server
  
  
  VERBOSE: Passed: Found module [avm/res/key-vault/vault] in the MCR catalog
  VERBOSE: Requested HTTP/1.1 GET with 0-byte payload
  VERBOSE: Received HTTP/1.1 87-byte response of content type application/json
  VERBOSE: Tags for module in path [avm/res/key-vault/vault] found in MCR catalog:
  0.2.0
  0.3.0
  
  Passed: Found new tag [0.3] for published module

@AlexanderSehr AlexanderSehr marked this pull request as ready for review November 24, 2023 21:34
@AlexanderSehr AlexanderSehr requested review from a team as code owners November 24, 2023 21:34
Copy link
Contributor

@ChrisSidebotham ChrisSidebotham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤌

@AlexanderSehr AlexanderSehr requested a review from eriqua December 2, 2023 12:29
@AlexanderSehr AlexanderSehr enabled auto-merge (squash) December 2, 2023 12:29
Copy link
Contributor

@eriqua eriqua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🆗

@AlexanderSehr AlexanderSehr merged commit 4ae6c8f into Azure:main Dec 3, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs: Triage 🔍 Maintainers need to triage still Type: AVM 🅰️ ✌️ Ⓜ️ This is an AVM related issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants